⚙️ CodeRabbit configuration file

examples/**/*: You are acting as a senior maintainer reviewing SDK examples. Your goal is to ensure examples work verbatim for users who copy-paste them.

Priority 1 - Correctness:

• Verify transaction lifecycle chain (construction -> freeze_with -> sign -> execute).
• Ensure freeze_with(client) is called BEFORE signing.
• Validate that methods referenced actually exist in the hiero_sdk_python codebase.
• Ensure response validation checks receipt.status against ResponseCode enums (e.g., ResponseCode.SUCCESS).

Priority 2 - Transaction Lifecycle:

• Check method chaining logic.
• Verify correct signing order (especially for multi-sig).
• Ensure explicit .execute(client) calls.
• Verify response property extraction (e.g., using .token_id, .account_id, .serial_numbers).
• Ensure error handling uses ResponseCode(receipt.status).name for clarity.

Priority 3 - Naming & Clarity:

• Enforce role-based naming: operator_id/_key, treasury_account_id/_key, receiver_id/_key.
• Use _id suffix for AccountId and _key suffix for PrivateKey variables.
• Validate negative examples explicitly check for failure codes (e.g., TOKEN_HAS_NO_PAUSE_KEY).
• Ensure logical top-to-bottom flow without ambiguity.

Priority 4 - Consistency:

• Verify standard patterns: def main(), if __name__ == "__main__":, load_dotenv().
• IMPORT RULES:
  1. Accept both top-level imports (e.g., from hiero_sdk_python import PrivateKey) and fully qualified imports (e.g., from hiero_sdk_python.crypto.private_key import PrivateKey).
  2. STRICTLY validate that the import path actually exists in the project structure. Compare against other files in /examples or your knowledge of the SDK file tree.
  3. Flag hallucinations immediately (e.g., hiero_sdk_python.keys does not exist).
• Check for try-except blocks with sys.exit(1) for critical failures.

Priority 5 - User Experience:

• Ensure comments explain SDK usage patterns (for users,...

Files:

• examples/contract/ethereum_transaction.py
• examples/contract/contract_execute_transaction.py
• examples/contract/contract_call_query.py

⚙️ CodeRabbit configuration file

tests/unit/**/*: You are acting as a senior maintainer reviewing unit tests for the hiero-sdk-python project. Your goal is to ensure tests are extensive, deterministic, and protect against breaking changes.

CRITICAL PRINCIPLES - Tests Must Fail Loudly & Deterministically:

• Tests must provide useful error messages when they fail for future debugging.
• No print() statements - use assertions with descriptive messages.
• No timing-dependent or unseeded random assertions.
• No network calls or external dependencies (unit tests are isolated).
• No unjustified TODOs or skipped tests without tracking issues.

PRIORITY 1 - Protect Against Breaking Changes:

• Assert public attributes exist (e.g., assert hasattr(obj, 'account_id')).
• Assert return types where relevant (e.g., assert isinstance(result, AccountId)).
• Assert fluent setters return self (e.g., assert tx.set_memo("test") is tx).
• Assert backward-compatible defaults are maintained.
• If a breaking change is introduced, tests must assert deprecation behavior and test old behavior until removal.

PRIORITY 2 - Constructor & Setter Behavior:

• Test constructor behavior with valid inputs, edge cases, and invalid inputs.
• Test setter behavior including method chaining (fluent interface).
• Verify that setters validate input and raise appropriate exceptions.
• Test that getters return expected values after construction/setting.

PRIORITY 3 - Comprehensive Coverage:

• Unit tests should be extensive - test even if we don't expect users to use it currently.
• Cover happy paths AND unhappy paths/edge cases.
• Test boundary conditions, null/None values, empty collections, etc.
• Avoid brittle ordering assertions unless order is part of the contract.

PRIORITY 4 - No Mocks for Non-Existent Modules:

• All imports must reference actual SDK modules - no hallucinated paths.
• Validate import paths against the actual src/hiero_sdk_python structure.
• Mocks should only be used for external de...

Files:

• tests/unit/client_test.py
• tests/unit/query_test.py

⚙️ CodeRabbit configuration file

tests/integration/**/*: You are acting as a senior maintainer reviewing integration tests for the hiero-sdk-python project. Your goal is to ensure end-to-end tests validate real network behavior safely and deterministically.

CRITICAL PRINCIPLES - Safety & Diagnosability:

• Prioritize safety: No implicit or default mainnet usage.
• Secrets and credentials must be injected safely (env vars, not hardcoded).
• Test failures must be diagnosable with clear error messages.
• Tests must assert observable network behavior, not just SUCCESS.
• Failure-path tests must assert specific ResponseCode values (e.g., TOKEN_HAS_NO_PAUSE_KEY).

PRIORITY 1 - End-to-End Behavior:

• Tests should be end-to-end: construct → freeze → sign → execute → verify.
• Validate resulting balances, ownership, and state changes (not just transaction success).
• Assert transaction receipts contain expected data (IDs, serial numbers, etc.).
• Verify network state after operations (e.g., account balance changed, token transferred).

PRIORITY 2 - Test Structure & Maintainability:

• One major behavior per test (clear focus).
• Tests should be readable: clear names, brief docstrings, key inline comments.
• Minimal abstraction layers - prefer clarity over DRY.
• Is the file too monolithic? Flag if tests should be split into smaller modules.
• Are helper functions good candidates for pytest fixtures or shared utilities?

PRIORITY 3 - Isolation & Cleanup:

• Local account creation over operator reuse (avoid state pollution).
• Are accounts, tokens, and allowances properly cleaned up to avoid state leakage?
• Recommend teardown strategies or fixture scoping improvements.
• Tests should not depend on execution order (avoid brittle assumptions).

PRIORITY 4 - Assertions & Coverage:

• Do tests validate only success/failure, or also assert resulting state?
• Suggest additional assertions that would strengthen correctness (balances, allowances, ownership).
• Cover happy paths AND ...

Files:

• tests/integration/contract_call_query_e2e_test.py

src/hiero_sdk_python/contract/contract_call_query.py (1)

• ContractCallQuery (27-233)

src/hiero_sdk_python/query/query.py (2)

• get_cost (281-321)
• set_max_query_payment (96-124)

src/hiero_sdk_python/hbar.py (1)

• Hbar (18-213)

src/hiero_sdk_python/client/client.py (4)

• Client (32-287)
• from_env (59-103)
• for_testnet (106-115)
• set_default_max_query_payment (249-274)

src/hiero_sdk_python/hbar.py (1)

• Hbar (18-213)

src/hiero_sdk_python/contract/contract_call_query.py (1)

• ContractCallQuery (27-233)

src/hiero_sdk_python/query/query.py (2)

• get_cost (281-321)
• set_max_query_payment (96-124)

src/hiero_sdk_python/hbar.py (2)

• Hbar (18-213)
• to_hbars (67-71)

src/hiero_sdk_python/query/query.py (4)

• set_max_query_payment (96-124)
• _is_payment_required (414-421)
• get_cost (281-321)
• _before_execute (126-157)

src/hiero_sdk_python/hbar.py (1)

• Hbar (18-213)

src/hiero_sdk_python/client/client.py (1)

• set_default_max_query_payment (249-274)

src/hiero_sdk_python/contract/contract_call_query.py (1)

• execute (190-216)

src/hiero_sdk_python/query/query.py (2)

• get_cost (281-321)
• set_max_query_payment (96-124)

src/hiero_sdk_python/query/query.py (2)

• get_cost (281-321)
• set_max_query_payment (96-124)

192-192: Wrong type passed to first argument of pytest.mark.parametrize; expected tuple

Use a tuple for the first argument

(PT006)

7-7: typing.List is deprecated, use list instead

(UP035)

249-249: Use X | Y for type annotations

Convert to X | Y

(UP007)

263-265: Avoid specifying long messages outside the exception class

(TRY003)

269-269: Avoid specifying long messages outside the exception class

(TRY003)

96-96: Use X | Y for type annotations

Convert to X | Y

(UP007)

113-115: Avoid specifying long messages outside the exception class

(TRY003)

119-119: Avoid specifying long messages outside the exception class

(TRY003)

154-157: Avoid specifying long messages outside the exception class

(TRY003)

251-251: Avoid equality comparisons to True; use query_requires_payment._is_payment_required(): for truth checks

Replace with query_requires_payment._is_payment_required()

(E712)

254-254: Wrong type passed to first argument of pytest.mark.parametrize; expected tuple

Use a tuple for the first argument

(PT006)

⚙️ CodeRabbit configuration file

examples/**/*: You are acting as a senior maintainer reviewing SDK examples. Your goal is to ensure examples work verbatim for users who copy-paste them.

Priority 1 - Correctness:

• Verify transaction lifecycle chain (construction -> freeze_with -> sign -> execute).
• Ensure freeze_with(client) is called BEFORE signing.
• Validate that methods referenced actually exist in the hiero_sdk_python codebase.
• Ensure response validation checks receipt.status against ResponseCode enums (e.g., ResponseCode.SUCCESS).

Priority 2 - Transaction Lifecycle:

• Check method chaining logic.
• Verify correct signing order (especially for multi-sig).
• Ensure explicit .execute(client) calls.
• Verify response property extraction (e.g., using .token_id, .account_id, .serial_numbers).
• Ensure error handling uses ResponseCode(receipt.status).name for clarity.

Priority 3 - Naming & Clarity:

• Enforce role-based naming: operator_id/_key, treasury_account_id/_key, receiver_id/_key.
• Use _id suffix for AccountId and _key suffix for PrivateKey variables.
• Validate negative examples explicitly check for failure codes (e.g., TOKEN_HAS_NO_PAUSE_KEY).
• Ensure logical top-to-bottom flow without ambiguity.

Priority 4 - Consistency:

• Verify standard patterns: def main(), if __name__ == "__main__":, load_dotenv().
• IMPORT RULES:
  1. Accept both top-level imports (e.g., from hiero_sdk_python import PrivateKey) and fully qualified imports (e.g., from hiero_sdk_python.crypto.private_key import PrivateKey).
  2. STRICTLY validate that the import path actually exists in the project structure. Compare against other files in /examples or your knowledge of the SDK file tree.
  3. Flag hallucinations immediately (e.g., hiero_sdk_python.keys does not exist).
• Check for try-except blocks with sys.exit(1) for critical failures.

Priority 5 - User Experience:

• Ensure comments explain SDK usage patterns (for users,...

Files:

• examples/contract/contract_execute_transaction.py
• examples/contract/ethereum_transaction.py
• examples/contract/contract_call_query.py

⚙️ CodeRabbit configuration file

tests/unit/**/*: You are acting as a senior maintainer reviewing unit tests for the hiero-sdk-python project. Your goal is to ensure tests are extensive, deterministic, and protect against breaking changes.

CRITICAL PRINCIPLES - Tests Must Fail Loudly & Deterministically:

• Tests must provide useful error messages when they fail for future debugging.
• No print() statements - use assertions with descriptive messages.
• No timing-dependent or unseeded random assertions.
• No network calls or external dependencies (unit tests are isolated).
• No unjustified TODOs or skipped tests without tracking issues.

PRIORITY 1 - Protect Against Breaking Changes:

• Assert public attributes exist (e.g., assert hasattr(obj, 'account_id')).
• Assert return types where relevant (e.g., assert isinstance(result, AccountId)).
• Assert fluent setters return self (e.g., assert tx.set_memo("test") is tx).
• Assert backward-compatible defaults are maintained.
• If a breaking change is introduced, tests must assert deprecation behavior and test old behavior until removal.

PRIORITY 2 - Constructor & Setter Behavior:

• Test constructor behavior with valid inputs, edge cases, and invalid inputs.
• Test setter behavior including method chaining (fluent interface).
• Verify that setters validate input and raise appropriate exceptions.
• Test that getters return expected values after construction/setting.

PRIORITY 3 - Comprehensive Coverage:

• Unit tests should be extensive - test even if we don't expect users to use it currently.
• Cover happy paths AND unhappy paths/edge cases.
• Test boundary conditions, null/None values, empty collections, etc.
• Avoid brittle ordering assertions unless order is part of the contract.

PRIORITY 4 - No Mocks for Non-Existent Modules:

• All imports must reference actual SDK modules - no hallucinated paths.
• Validate import paths against the actual src/hiero_sdk_python structure.
• Mocks should only be used for external de...

Files:

• tests/unit/client_test.py
• tests/unit/query_test.py

⚙️ CodeRabbit configuration file

tests/integration/**/*: You are acting as a senior maintainer reviewing integration tests for the hiero-sdk-python project. Your goal is to ensure end-to-end tests validate real network behavior safely and deterministically.

CRITICAL PRINCIPLES - Safety & Diagnosability:

• Prioritize safety: No implicit or default mainnet usage.
• Secrets and credentials must be injected safely (env vars, not hardcoded).
• Test failures must be diagnosable with clear error messages.
• Tests must assert observable network behavior, not just SUCCESS.
• Failure-path tests must assert specific ResponseCode values (e.g., TOKEN_HAS_NO_PAUSE_KEY).

PRIORITY 1 - End-to-End Behavior:

• Tests should be end-to-end: construct → freeze → sign → execute → verify.
• Validate resulting balances, ownership, and state changes (not just transaction success).
• Assert transaction receipts contain expected data (IDs, serial numbers, etc.).
• Verify network state after operations (e.g., account balance changed, token transferred).

PRIORITY 2 - Test Structure & Maintainability:

• One major behavior per test (clear focus).
• Tests should be readable: clear names, brief docstrings, key inline comments.
• Minimal abstraction layers - prefer clarity over DRY.
• Is the file too monolithic? Flag if tests should be split into smaller modules.
• Are helper functions good candidates for pytest fixtures or shared utilities?

PRIORITY 3 - Isolation & Cleanup:

• Local account creation over operator reuse (avoid state pollution).
• Are accounts, tokens, and allowances properly cleaned up to avoid state leakage?
• Recommend teardown strategies or fixture scoping improvements.
• Tests should not depend on execution order (avoid brittle assumptions).

PRIORITY 4 - Assertions & Coverage:

• Do tests validate only success/failure, or also assert resulting state?
• Suggest additional assertions that would strengthen correctness (balances, allowances, ownership).
• Cover happy paths AND ...

Files:

• tests/integration/contract_call_query_e2e_test.py
• tests/integration/query_e2e_test.py

src/hiero_sdk_python/contract/contract_call_query.py (1)

• ContractCallQuery (27-233)

src/hiero_sdk_python/query/query.py (2)

• get_cost (281-321)
• set_max_query_payment (96-124)

src/hiero_sdk_python/contract/contract_call_query.py (1)

• ContractCallQuery (27-233)

src/hiero_sdk_python/query/query.py (2)

• get_cost (281-321)
• set_max_query_payment (96-124)

src/hiero_sdk_python/hbar.py (1)

• Hbar (18-213)

src/hiero_sdk_python/hbar.py (1)

• Hbar (18-213)

src/hiero_sdk_python/client/client.py (2)

• Client (32-287)
• set_default_max_query_payment (249-274)

src/hiero_sdk_python/query/query.py (4)

• set_max_query_payment (96-124)
• _is_payment_required (414-421)
• get_cost (281-321)
• _before_execute (126-157)

src/hiero_sdk_python/hbar.py (1)

• Hbar (18-213)

src/hiero_sdk_python/client/client.py (1)

• set_default_max_query_payment (249-274)

src/hiero_sdk_python/contract/contract_call_query.py (5)

• ContractCallQuery (27-233)
• set_contract_id (59-67)
• set_gas (69-77)
• set_function (107-124)
• execute (190-216)

src/hiero_sdk_python/query/query.py (2)

• get_cost (281-321)
• set_max_query_payment (96-124)

src/hiero_sdk_python/query/account_info_query.py (1)

• AccountInfoQuery (11-131)

src/hiero_sdk_python/query/query.py (1)

• set_max_query_payment (96-124)

src/hiero_sdk_python/contract/contract_call_query.py (1)

• ContractCallQuery (27-233)

src/hiero_sdk_python/query/query.py (2)

• get_cost (281-321)
• set_max_query_payment (96-124)

7-7: typing.List is deprecated, use list instead

(UP035)

249-249: Use X | Y for type annotations

Convert to X | Y

(UP007)

263-265: Avoid specifying long messages outside the exception class

(TRY003)

269-269: Avoid specifying long messages outside the exception class

(TRY003)

192-192: Wrong type passed to first argument of pytest.mark.parametrize; expected tuple

Use a tuple for the first argument

(PT006)

96-96: Use X | Y for type annotations

Convert to X | Y

(UP007)

113-115: Avoid specifying long messages outside the exception class

(TRY003)

119-119: Avoid specifying long messages outside the exception class

(TRY003)

154-157: Avoid specifying long messages outside the exception class

(TRY003)

251-251: Avoid equality comparisons to True; use query_requires_payment._is_payment_required(): for truth checks

Replace with query_requires_payment._is_payment_required()

(E712)

254-254: Wrong type passed to first argument of pytest.mark.parametrize; expected tuple

Use a tuple for the first argument

(PT006)

255-255: pytest.raises(ValueError) is too broad, set the match parameter or use a more specific exception

(PT011)

259-259: Assertion should be broken down into multiple parts

Break down assertion into multiple parts

(PT018)

⚙️ CodeRabbit configuration file

tests/integration/**/*: You are acting as a senior maintainer reviewing integration tests for the hiero-sdk-python project. Your goal is to ensure end-to-end tests validate real network behavior safely and deterministically.

CRITICAL PRINCIPLES - Safety & Diagnosability:

• Prioritize safety: No implicit or default mainnet usage.
• Secrets and credentials must be injected safely (env vars, not hardcoded).
• Test failures must be diagnosable with clear error messages.
• Tests must assert observable network behavior, not just SUCCESS.
• Failure-path tests must assert specific ResponseCode values (e.g., TOKEN_HAS_NO_PAUSE_KEY).

PRIORITY 1 - End-to-End Behavior:

• Tests should be end-to-end: construct → freeze → sign → execute → verify.
• Validate resulting balances, ownership, and state changes (not just transaction success).
• Assert transaction receipts contain expected data (IDs, serial numbers, etc.).
• Verify network state after operations (e.g., account balance changed, token transferred).

PRIORITY 2 - Test Structure & Maintainability:

• One major behavior per test (clear focus).
• Tests should be readable: clear names, brief docstrings, key inline comments.
• Minimal abstraction layers - prefer clarity over DRY.
• Is the file too monolithic? Flag if tests should be split into smaller modules.
• Are helper functions good candidates for pytest fixtures or shared utilities?

PRIORITY 3 - Isolation & Cleanup:

• Local account creation over operator reuse (avoid state pollution).
• Are accounts, tokens, and allowances properly cleaned up to avoid state leakage?
• Recommend teardown strategies or fixture scoping improvements.
• Tests should not depend on execution order (avoid brittle assumptions).

PRIORITY 4 - Assertions & Coverage:

• Do tests validate only success/failure, or also assert resulting state?
• Suggest additional assertions that would strengthen correctness (balances, allowances, ownership).
• Cover happy paths AND ...

Files:

• tests/integration/query_e2e_test.py

⚙️ CodeRabbit configuration file

tests/unit/**/*: You are acting as a senior maintainer reviewing unit tests for the hiero-sdk-python project. Your goal is to ensure tests are extensive, deterministic, and protect against breaking changes.

CRITICAL PRINCIPLES - Tests Must Fail Loudly & Deterministically:

• Tests must provide useful error messages when they fail for future debugging.
• No print() statements - use assertions with descriptive messages.
• No timing-dependent or unseeded random assertions.
• No network calls or external dependencies (unit tests are isolated).
• No unjustified TODOs or skipped tests without tracking issues.

PRIORITY 1 - Protect Against Breaking Changes:

• Assert public attributes exist (e.g., assert hasattr(obj, 'account_id')).
• Assert return types where relevant (e.g., assert isinstance(result, AccountId)).
• Assert fluent setters return self (e.g., assert tx.set_memo("test") is tx).
• Assert backward-compatible defaults are maintained.
• If a breaking change is introduced, tests must assert deprecation behavior and test old behavior until removal.

PRIORITY 2 - Constructor & Setter Behavior:

• Test constructor behavior with valid inputs, edge cases, and invalid inputs.
• Test setter behavior including method chaining (fluent interface).
• Verify that setters validate input and raise appropriate exceptions.
• Test that getters return expected values after construction/setting.

PRIORITY 3 - Comprehensive Coverage:

• Unit tests should be extensive - test even if we don't expect users to use it currently.
• Cover happy paths AND unhappy paths/edge cases.
• Test boundary conditions, null/None values, empty collections, etc.
• Avoid brittle ordering assertions unless order is part of the contract.

PRIORITY 4 - No Mocks for Non-Existent Modules:

• All imports must reference actual SDK modules - no hallucinated paths.
• Validate import paths against the actual src/hiero_sdk_python structure.
• Mocks should only be used for external de...

Files:

• tests/unit/query_test.py

src/hiero_sdk_python/query/account_info_query.py (1)

• AccountInfoQuery (11-131)

tests/integration/utils.py (2)

• IntegrationTestEnv (34-96)
• env (23-27)

src/hiero_sdk_python/query/query.py (1)

• set_max_query_payment (96-124)

src/hiero_sdk_python/query/query.py (4)

• set_max_query_payment (96-124)
• _is_payment_required (414-421)
• get_cost (281-321)
• _before_execute (126-157)

src/hiero_sdk_python/hbar.py (1)

• Hbar (18-213)

src/hiero_sdk_python/client/client.py (1)

• set_default_max_query_payment (249-274)

243-243: Redefinition of unused env from line 12

(F811)

255-255: pytest.raises(ValueError) is too broad, set the match parameter or use a more specific exception

(PT011)

259-259: Assertion should be broken down into multiple parts

Break down assertion into multiple parts

(PT018)

251-251: Avoid equality comparisons to True; use query_requires_payment._is_payment_required(): for truth checks

Replace with query_requires_payment._is_payment_required()

(E712)

254-254: Wrong type passed to first argument of pytest.mark.parametrize; expected tuple

Use a tuple for the first argument

(PT006)

⚙️ CodeRabbit configuration file

examples/**/*: You are acting as a senior maintainer reviewing SDK examples. Your goal is to ensure examples work verbatim for users who copy-paste them.

Priority 1 - Correctness:

• Verify transaction lifecycle chain (construction -> freeze_with -> sign -> execute).
• Ensure freeze_with(client) is called BEFORE signing.
• Validate that methods referenced actually exist in the hiero_sdk_python codebase.
• Ensure response validation checks receipt.status against ResponseCode enums (e.g., ResponseCode.SUCCESS).

Priority 2 - Transaction Lifecycle:

• Check method chaining logic.
• Verify correct signing order (especially for multi-sig).
• Ensure explicit .execute(client) calls.
• Verify response property extraction (e.g., using .token_id, .account_id, .serial_numbers).
• Ensure error handling uses ResponseCode(receipt.status).name for clarity.

Priority 3 - Naming & Clarity:

• Enforce role-based naming: operator_id/_key, treasury_account_id/_key, receiver_id/_key.
• Use _id suffix for AccountId and _key suffix for PrivateKey variables.
• Validate negative examples explicitly check for failure codes (e.g., TOKEN_HAS_NO_PAUSE_KEY).
• Ensure logical top-to-bottom flow without ambiguity.

Priority 4 - Consistency:

• Verify standard patterns: def main(), if __name__ == "__main__":, load_dotenv().
• IMPORT RULES:
  1. Accept both top-level imports (e.g., from hiero_sdk_python import PrivateKey) and fully qualified imports (e.g., from hiero_sdk_python.crypto.private_key import PrivateKey).
  2. STRICTLY validate that the import path actually exists in the project structure. Compare against other files in /examples or your knowledge of the SDK file tree.
  3. Flag hallucinations immediately (e.g., hiero_sdk_python.keys does not exist).
• Check for try-except blocks with sys.exit(1) for critical failures.

Priority 5 - User Experience:

• Ensure comments explain SDK usage patterns (for users,...

Files:

• examples/contract/ethereum_transaction.py
• examples/contract/contract_execute_transaction.py
• examples/contract/contract_call_query.py

⚙️ CodeRabbit configuration file

tests/unit/**/*: You are acting as a senior maintainer reviewing unit tests for the hiero-sdk-python project. Your goal is to ensure tests are extensive, deterministic, and protect against breaking changes.

CRITICAL PRINCIPLES - Tests Must Fail Loudly & Deterministically:

• Tests must provide useful error messages when they fail for future debugging.
• No print() statements - use assertions with descriptive messages.
• No timing-dependent or unseeded random assertions.
• No network calls or external dependencies (unit tests are isolated).
• No unjustified TODOs or skipped tests without tracking issues.

PRIORITY 1 - Protect Against Breaking Changes:

• Assert public attributes exist (e.g., assert hasattr(obj, 'account_id')).
• Assert return types where relevant (e.g., assert isinstance(result, AccountId)).
• Assert fluent setters return self (e.g., assert tx.set_memo("test") is tx).
• Assert backward-compatible defaults are maintained.
• If a breaking change is introduced, tests must assert deprecation behavior and test old behavior until removal.

PRIORITY 2 - Constructor & Setter Behavior:

• Test constructor behavior with valid inputs, edge cases, and invalid inputs.
• Test setter behavior including method chaining (fluent interface).
• Verify that setters validate input and raise appropriate exceptions.
• Test that getters return expected values after construction/setting.

PRIORITY 3 - Comprehensive Coverage:

• Unit tests should be extensive - test even if we don't expect users to use it currently.
• Cover happy paths AND unhappy paths/edge cases.
• Test boundary conditions, null/None values, empty collections, etc.
• Avoid brittle ordering assertions unless order is part of the contract.

PRIORITY 4 - No Mocks for Non-Existent Modules:

• All imports must reference actual SDK modules - no hallucinated paths.
• Validate import paths against the actual src/hiero_sdk_python structure.
• Mocks should only be used for external de...

Files:

• tests/unit/client_test.py
• tests/unit/query_test.py

⚙️ CodeRabbit configuration file

tests/integration/**/*: You are acting as a senior maintainer reviewing integration tests for the hiero-sdk-python project. Your goal is to ensure end-to-end tests validate real network behavior safely and deterministically.

CRITICAL PRINCIPLES - Safety & Diagnosability:

• Prioritize safety: No implicit or default mainnet usage.
• Secrets and credentials must be injected safely (env vars, not hardcoded).
• Test failures must be diagnosable with clear error messages.
• Tests must assert observable network behavior, not just SUCCESS.
• Failure-path tests must assert specific ResponseCode values (e.g., TOKEN_HAS_NO_PAUSE_KEY).

PRIORITY 1 - End-to-End Behavior:

• Tests should be end-to-end: construct → freeze → sign → execute → verify.
• Validate resulting balances, ownership, and state changes (not just transaction success).
• Assert transaction receipts contain expected data (IDs, serial numbers, etc.).
• Verify network state after operations (e.g., account balance changed, token transferred).

PRIORITY 2 - Test Structure & Maintainability:

• One major behavior per test (clear focus).
• Tests should be readable: clear names, brief docstrings, key inline comments.
• Minimal abstraction layers - prefer clarity over DRY.
• Is the file too monolithic? Flag if tests should be split into smaller modules.
• Are helper functions good candidates for pytest fixtures or shared utilities?

PRIORITY 3 - Isolation & Cleanup:

• Local account creation over operator reuse (avoid state pollution).
• Are accounts, tokens, and allowances properly cleaned up to avoid state leakage?
• Recommend teardown strategies or fixture scoping improvements.
• Tests should not depend on execution order (avoid brittle assumptions).

PRIORITY 4 - Assertions & Coverage:

• Do tests validate only success/failure, or also assert resulting state?
• Suggest additional assertions that would strengthen correctness (balances, allowances, ownership).
• Cover happy paths AND ...

Files:

• tests/integration/query_e2e_test.py
• tests/integration/contract_call_query_e2e_test.py

src/hiero_sdk_python/contract/contract_call_query.py (1)

• ContractCallQuery (27-233)

src/hiero_sdk_python/query/query.py (2)

• get_cost (281-321)
• set_max_query_payment (96-124)

src/hiero_sdk_python/hbar.py (2)

• Hbar (18-213)
• to_hbars (67-71)

src/hiero_sdk_python/hbar.py (1)

• Hbar (18-213)

src/hiero_sdk_python/client/client.py (2)

• Client (32-287)
• set_default_max_query_payment (249-274)

src/hiero_sdk_python/hbar.py (1)

• Hbar (18-213)

src/hiero_sdk_python/contract/contract_call_query.py (1)

• ContractCallQuery (27-233)

src/hiero_sdk_python/query/query.py (2)

• get_cost (281-321)
• set_max_query_payment (96-124)

src/hiero_sdk_python/query/query.py (2)

• get_cost (281-321)
• set_max_query_payment (96-124)

src/hiero_sdk_python/query/query.py (4)

• set_max_query_payment (96-124)
• _is_payment_required (414-421)
• get_cost (281-321)
• _before_execute (126-157)

src/hiero_sdk_python/client/client.py (1)

• set_default_max_query_payment (249-274)

96-96: Use X | Y for type annotations

Convert to X | Y

(UP007)

113-115: Avoid specifying long messages outside the exception class

(TRY003)

119-119: Avoid specifying long messages outside the exception class

(TRY003)

154-157: Avoid specifying long messages outside the exception class

(TRY003)

192-192: Wrong type passed to first argument of pytest.mark.parametrize; expected tuple

Use a tuple for the first argument

(PT006)

7-7: typing.List is deprecated, use list instead

(UP035)

249-249: Use X | Y for type annotations

Convert to X | Y

(UP007)

263-265: Avoid specifying long messages outside the exception class

(TRY003)

269-269: Avoid specifying long messages outside the exception class

(TRY003)

243-243: Redefinition of unused env from line 12

(F811)

255-255: pytest.raises(ValueError) is too broad, set the match parameter or use a more specific exception

(PT011)

259-259: Assertion should be broken down into multiple parts

Break down assertion into multiple parts

(PT018)

251-251: Avoid equality comparisons to True; use query_requires_payment._is_payment_required(): for truth checks

Replace with query_requires_payment._is_payment_required()

(E712)

254-254: Wrong type passed to first argument of pytest.mark.parametrize; expected tuple

Use a tuple for the first argument

(PT006)

⚙️ CodeRabbit configuration file

examples/**/*: You are acting as a senior maintainer reviewing SDK examples. Your goal is to ensure examples work verbatim for users who copy-paste them.

Priority 1 - Correctness:

• Verify transaction lifecycle chain (construction -> freeze_with -> sign -> execute).
• Ensure freeze_with(client) is called BEFORE signing.
• Validate that methods referenced actually exist in the hiero_sdk_python codebase.
• Ensure response validation checks receipt.status against ResponseCode enums (e.g., ResponseCode.SUCCESS).

Priority 2 - Transaction Lifecycle:

• Check method chaining logic.
• Verify correct signing order (especially for multi-sig).
• Ensure explicit .execute(client) calls.
• Verify response property extraction (e.g., using .token_id, .account_id, .serial_numbers).
• Ensure error handling uses ResponseCode(receipt.status).name for clarity.

Priority 3 - Naming & Clarity:

• Enforce role-based naming: operator_id/_key, treasury_account_id/_key, receiver_id/_key.
• Use _id suffix for AccountId and _key suffix for PrivateKey variables.
• Validate negative examples explicitly check for failure codes (e.g., TOKEN_HAS_NO_PAUSE_KEY).
• Ensure logical top-to-bottom flow without ambiguity.

Priority 4 - Consistency:

• Verify standard patterns: def main(), if __name__ == "__main__":, load_dotenv().
• IMPORT RULES:
  1. Accept both top-level imports (e.g., from hiero_sdk_python import PrivateKey) and fully qualified imports (e.g., from hiero_sdk_python.crypto.private_key import PrivateKey).
  2. STRICTLY validate that the import path actually exists in the project structure. Compare against other files in /examples or your knowledge of the SDK file tree.
  3. Flag hallucinations immediately (e.g., hiero_sdk_python.keys does not exist).
• Check for try-except blocks with sys.exit(1) for critical failures.

Priority 5 - User Experience:

• Ensure comments explain SDK usage patterns (for users,...

Files:

• examples/contract/contract_execute_transaction.py
• examples/contract/ethereum_transaction.py
• examples/contract/contract_call_query.py

⚙️ CodeRabbit configuration file

tests/integration/**/*: You are acting as a senior maintainer reviewing integration tests for the hiero-sdk-python project. Your goal is to ensure end-to-end tests validate real network behavior safely and deterministically.

CRITICAL PRINCIPLES - Safety & Diagnosability:

• Prioritize safety: No implicit or default mainnet usage.
• Secrets and credentials must be injected safely (env vars, not hardcoded).
• Test failures must be diagnosable with clear error messages.
• Tests must assert observable network behavior, not just SUCCESS.
• Failure-path tests must assert specific ResponseCode values (e.g., TOKEN_HAS_NO_PAUSE_KEY).

PRIORITY 1 - End-to-End Behavior:

• Tests should be end-to-end: construct → freeze → sign → execute → verify.
• Validate resulting balances, ownership, and state changes (not just transaction success).
• Assert transaction receipts contain expected data (IDs, serial numbers, etc.).
• Verify network state after operations (e.g., account balance changed, token transferred).

PRIORITY 2 - Test Structure & Maintainability:

• One major behavior per test (clear focus).
• Tests should be readable: clear names, brief docstrings, key inline comments.
• Minimal abstraction layers - prefer clarity over DRY.
• Is the file too monolithic? Flag if tests should be split into smaller modules.
• Are helper functions good candidates for pytest fixtures or shared utilities?

PRIORITY 3 - Isolation & Cleanup:

• Local account creation over operator reuse (avoid state pollution).
• Are accounts, tokens, and allowances properly cleaned up to avoid state leakage?
• Recommend teardown strategies or fixture scoping improvements.
• Tests should not depend on execution order (avoid brittle assumptions).

PRIORITY 4 - Assertions & Coverage:

• Do tests validate only success/failure, or also assert resulting state?
• Suggest additional assertions that would strengthen correctness (balances, allowances, ownership).
• Cover happy paths AND ...

Files:

• tests/integration/query_e2e_test.py
• tests/integration/contract_call_query_e2e_test.py

⚙️ CodeRabbit configuration file

tests/unit/**/*: You are acting as a senior maintainer reviewing unit tests for the hiero-sdk-python project. Your goal is to ensure tests are extensive, deterministic, and protect against breaking changes.

CRITICAL PRINCIPLES - Tests Must Fail Loudly & Deterministically:

• Tests must provide useful error messages when they fail for future debugging.
• No print() statements - use assertions with descriptive messages.
• No timing-dependent or unseeded random assertions.
• No network calls or external dependencies (unit tests are isolated).
• No unjustified TODOs or skipped tests without tracking issues.

PRIORITY 1 - Protect Against Breaking Changes:

• Assert public attributes exist (e.g., assert hasattr(obj, 'account_id')).
• Assert return types where relevant (e.g., assert isinstance(result, AccountId)).
• Assert fluent setters return self (e.g., assert tx.set_memo("test") is tx).
• Assert backward-compatible defaults are maintained.
• If a breaking change is introduced, tests must assert deprecation behavior and test old behavior until removal.

PRIORITY 2 - Constructor & Setter Behavior:

• Test constructor behavior with valid inputs, edge cases, and invalid inputs.
• Test setter behavior including method chaining (fluent interface).
• Verify that setters validate input and raise appropriate exceptions.
• Test that getters return expected values after construction/setting.

PRIORITY 3 - Comprehensive Coverage:

• Unit tests should be extensive - test even if we don't expect users to use it currently.
• Cover happy paths AND unhappy paths/edge cases.
• Test boundary conditions, null/None values, empty collections, etc.
• Avoid brittle ordering assertions unless order is part of the contract.

PRIORITY 4 - No Mocks for Non-Existent Modules:

• All imports must reference actual SDK modules - no hallucinated paths.
• Validate import paths against the actual src/hiero_sdk_python structure.
• Mocks should only be used for external de...

Files:

• tests/unit/client_test.py
• tests/unit/query_test.py

Learnt from: github-actions[bot]
Repo: hiero-ledger/hiero-sdk-python PR: 0
File: :0-0
Timestamp: 2026-01-08T10:28:14.391Z
Learning: In hiero-ledger/hiero-sdk-python, examples should prefer Client.from_env() (src/hiero_sdk_python/client/client.py) for client setup. For examples under examples/tokens, replace manual Network/AccountId/PrivateKey + load_dotenv() bootstrapping with Client.from_env(), and use client.operator_account_id and client.operator_private_key instead of passing operator_id/operator_key through functions.

Applied to files:

• tests/unit/client_test.py
• examples/contract/contract_call_query.py

src/hiero_sdk_python/contract/contract_call_query.py (1)

• ContractCallQuery (27-233)

src/hiero_sdk_python/query/query.py (2)

• get_cost (281-321)
• set_max_query_payment (96-124)

src/hiero_sdk_python/contract/contract_call_query.py (1)

• ContractCallQuery (27-233)

src/hiero_sdk_python/query/query.py (2)

• get_cost (281-321)
• set_max_query_payment (96-124)

src/hiero_sdk_python/query/account_info_query.py (1)

• AccountInfoQuery (11-131)

tests/integration/utils.py (3)

• IntegrationTestEnv (34-96)
• env (23-27)
• close (51-52)

src/hiero_sdk_python/query/query.py (1)

• set_max_query_payment (96-124)

src/hiero_sdk_python/query/query.py (2)

• get_cost (281-321)
• set_max_query_payment (96-124)

src/hiero_sdk_python/contract/contract_call_query.py (1)

• ContractCallQuery (27-233)

src/hiero_sdk_python/query/query.py (2)

• get_cost (281-321)
• set_max_query_payment (96-124)

src/hiero_sdk_python/query/query.py (4)

• set_max_query_payment (96-124)
• _is_payment_required (414-421)
• get_cost (281-321)
• _before_execute (126-157)

src/hiero_sdk_python/client/client.py (1)

• set_default_max_query_payment (249-274)

src/hiero_sdk_python/hbar.py (1)

• Hbar (18-213)

src/hiero_sdk_python/hbar.py (2)

• Hbar (18-213)
• to_hbars (67-71)

243-243: Redefinition of unused env from line 12

(F811)

255-255: pytest.raises(ValueError) is too broad, set the match parameter or use a more specific exception

(PT011)

259-259: Assertion should be broken down into multiple parts

Break down assertion into multiple parts

(PT018)

192-192: Wrong type passed to first argument of pytest.mark.parametrize; expected tuple

Use a tuple for the first argument

(PT006)

251-251: Avoid equality comparisons to True; use query_requires_payment._is_payment_required(): for truth checks

Replace with query_requires_payment._is_payment_required()

(E712)

254-254: Wrong type passed to first argument of pytest.mark.parametrize; expected tuple

Use a tuple for the first argument

(PT006)

7-7: typing.List is deprecated, use list instead

(UP035)

249-249: Use X | Y for type annotations

Convert to X | Y

(UP007)

263-265: Avoid specifying long messages outside the exception class

(TRY003)

269-269: Avoid specifying long messages outside the exception class

(TRY003)

96-96: Use X | Y for type annotations

Convert to X | Y

(UP007)

113-115: Avoid specifying long messages outside the exception class

(TRY003)

119-119: Avoid specifying long messages outside the exception class

(TRY003)

154-157: Avoid specifying long messages outside the exception class

(TRY003)

⚙️ CodeRabbit configuration file

src/hiero_sdk_python/query/**/*.py: You are acting as a senior maintainer reviewing the Query base class
and its subclasses for the hiero-sdk-python project.

NOTE:

• Review focus levels indicate areas that are important to check carefully.
• They do NOT imply severity or urgency.
• Only recommend fixes when there is a clear behavioral regression.

Scope is STRICTLY LIMITED to:

• Changes to the base Query class
• Changes to existing Query subclasses
• Newly added Query subclasses

---

REVIEW FOCUS 1 — QUERY SEMANTICS & PAYMENT BEHAVIOR
(CONTRACTUAL / HIGH SENSITIVITY)

Queries do not reach consensus and use QueryHeader for payment and responseType.

The following behaviors are contractual and must remain unchanged:

• _is_payment_required() semantics
• FREE vs PAID query classification
• COST_ANSWER vs ANSWER_ONLY behavior
• Whether a payment transaction is attached

Good to check and verify that changes do NOT:

• Alter FREE → PAID or PAID → FREE behavior
• Attach payment to COST_ANSWER queries
• Bypass get_cost(client) for paid queries
• Hardcode fees or override payment logic

---

REVIEW FOCUS 2 — EXECUTION LIFECYCLE & BASE CLASS INTEGRITY

All queries MUST:

• Use the base Query execution flow
• Delegate retries, backoff, and node selection to _Executable
• Call _before_execute(client) before _execute(client)

Subclasses MUST NOT:

• Override retry logic
• Implement custom node selection
• Manage gRPC deadlines manually
• Bypass _Executable state handling

Flag deviations for review; recommend fixes only if behavior changes.

---

REVIEW FOCUS 3 — REQUEST CONSTRUCTION CONTRACT

_make_request() MUST:

• Validat...

Files:

• src/hiero_sdk_python/query/query.py

⚙️ CodeRabbit configuration file

examples/**/*: You are acting as a senior maintainer reviewing SDK examples. Your goal is to ensure examples work verbatim for users who copy-paste them.

Priority 1 - Correctness:

• Verify transaction lifecycle chain (construction -> freeze_with -> sign -> execute).
• Ensure freeze_with(client) is called BEFORE signing.
• Validate that methods referenced actually exist in the hiero_sdk_python codebase.
• Ensure response validation checks receipt.status against ResponseCode enums (e.g., ResponseCode.SUCCESS).

Priority 2 - Transaction Lifecycle:

• Check method chaining logic.
• Verify correct signing order (especially for multi-sig).
• Ensure explicit .execute(client) calls.
• Verify response property extraction (e.g., using .token_id, .account_id, .serial_numbers).
• Ensure error handling uses ResponseCode(receipt.status).name for clarity.

Priority 3 - Naming & Clarity:

• Enforce role-based naming: operator_id/_key, treasury_account_id/_key, receiver_id/_key.
• Use _id suffix for AccountId and _key suffix for PrivateKey variables.
• Validate negative examples explicitly check for failure codes (e.g., TOKEN_HAS_NO_PAUSE_KEY).
• Ensure logical top-to-bottom flow without ambiguity.

Priority 4 - Consistency:

• Verify standard patterns: def main(), if __name__ == "__main__":, load_dotenv().
• IMPORT RULES:
  1. Accept both top-level imports (e.g., from hiero_sdk_python import PrivateKey) and fully qualified imports (e.g., from hiero_sdk_python.crypto.private_key import PrivateKey).
  2. STRICTLY validate that the import path actually exists in the project structure. Compare against other files in /examples or your knowledge of the SDK file tree.
  3. Flag hallucinations immediately (e.g., hiero_sdk_python.keys does not exist).
• Check for try-except blocks with sys.exit(1) for critical failures.

Priority 5 - User Experience:

• Ensure comments explain SDK usage patterns (for users,...

Files:

• examples/contract/contract_call_query.py
• examples/contract/ethereum_transaction.py
• examples/contract/contract_execute_transaction.py

⚙️ CodeRabbit configuration file

tests/integration/**/*: You are acting as a senior maintainer reviewing integration tests for the hiero-sdk-python project. Your goal is to ensure end-to-end tests validate real network behavior safely and deterministically.

CRITICAL PRINCIPLES - Safety & Diagnosability:

• Prioritize safety: No implicit or default mainnet usage.
• Secrets and credentials must be injected safely (env vars, not hardcoded).
• Test failures must be diagnosable with clear error messages.
• Tests must assert observable network behavior, not just SUCCESS.
• Failure-path tests must assert specific ResponseCode values (e.g., TOKEN_HAS_NO_PAUSE_KEY).

PRIORITY 1 - End-to-End Behavior:

• Tests should be end-to-end: construct → freeze → sign → execute → verify.
• Validate resulting balances, ownership, and state changes (not just transaction success).
• Assert transaction receipts contain expected data (IDs, serial numbers, etc.).
• Verify network state after operations (e.g., account balance changed, token transferred).

PRIORITY 2 - Test Structure & Maintainability:

• One major behavior per test (clear focus).
• Tests should be readable: clear names, brief docstrings, key inline comments.
• Minimal abstraction layers - prefer clarity over DRY.
• Is the file too monolithic? Flag if tests should be split into smaller modules.
• Are helper functions good candidates for pytest fixtures or shared utilities?

PRIORITY 3 - Isolation & Cleanup:

• Local account creation over operator reuse (avoid state pollution).
• Are accounts, tokens, and allowances properly cleaned up to avoid state leakage?
• Recommend teardown strategies or fixture scoping improvements.
• Tests should not depend on execution order (avoid brittle assumptions).

PRIORITY 4 - Assertions & Coverage:

• Do tests validate only success/failure, or also assert resulting state?
• Suggest additional assertions that would strengthen correctness (balances, allowances, ownership).
• Cover happy paths AND ...

Files:

• tests/integration/query_e2e_test.py
• tests/integration/contract_call_query_e2e_test.py

⚙️ CodeRabbit configuration file

tests/unit/**/*: You are acting as a senior maintainer reviewing unit tests for the hiero-sdk-python project. Your goal is to ensure tests are extensive, deterministic, and protect against breaking changes.

CRITICAL PRINCIPLES - Tests Must Fail Loudly & Deterministically:

• Tests must provide useful error messages when they fail for future debugging.
• No print() statements - use assertions with descriptive messages.
• No timing-dependent or unseeded random assertions.
• No network calls or external dependencies (unit tests are isolated).
• No unjustified TODOs or skipped tests without tracking issues.

PRIORITY 1 - Protect Against Breaking Changes:

• Assert public attributes exist (e.g., assert hasattr(obj, 'account_id')).
• Assert return types where relevant (e.g., assert isinstance(result, AccountId)).
• Assert fluent setters return self (e.g., assert tx.set_memo("test") is tx).
• Assert backward-compatible defaults are maintained.
• If a breaking change is introduced, tests must assert deprecation behavior and test old behavior until removal.

PRIORITY 2 - Constructor & Setter Behavior:

• Test constructor behavior with valid inputs, edge cases, and invalid inputs.
• Test setter behavior including method chaining (fluent interface).
• Verify that setters validate input and raise appropriate exceptions.
• Test that getters return expected values after construction/setting.

PRIORITY 3 - Comprehensive Coverage:

• Unit tests should be extensive - test even if we don't expect users to use it currently.
• Cover happy paths AND unhappy paths/edge cases.
• Test boundary conditions, null/None values, empty collections, etc.
• Avoid brittle ordering assertions unless order is part of the contract.

PRIORITY 4 - No Mocks for Non-Existent Modules:

• All imports must reference actual SDK modules - no hallucinated paths.
• Validate import paths against the actual src/hiero_sdk_python structure.
• Mocks should only be used for external de...

Files:

• tests/unit/query_test.py
• tests/unit/client_test.py

Learnt from: github-actions[bot]
Repo: hiero-ledger/hiero-sdk-python PR: 0
File: :0-0
Timestamp: 2026-01-08T10:28:14.391Z
Learning: In hiero-ledger/hiero-sdk-python, examples should prefer Client.from_env() (src/hiero_sdk_python/client/client.py) for client setup. For examples under examples/tokens, replace manual Network/AccountId/PrivateKey + load_dotenv() bootstrapping with Client.from_env(), and use client.operator_account_id and client.operator_private_key instead of passing operator_id/operator_key through functions.

Applied to files:

• examples/contract/contract_call_query.py
• tests/unit/client_test.py

src/hiero_sdk_python/hbar.py (2)

• Hbar (18-213)
• to_hbars (67-71)

src/hiero_sdk_python/contract/contract_call_query.py (1)

• ContractCallQuery (27-233)

src/hiero_sdk_python/query/query.py (2)

• get_cost (281-321)
• set_max_query_payment (96-124)

src/hiero_sdk_python/contract/contract_call_query.py (1)

• ContractCallQuery (27-233)

src/hiero_sdk_python/query/query.py (2)

• get_cost (281-321)
• set_max_query_payment (96-124)

src/hiero_sdk_python/hbar.py (1)

• Hbar (18-213)

src/hiero_sdk_python/query/account_info_query.py (1)

• AccountInfoQuery (11-131)

tests/integration/utils.py (4)

• IntegrationTestEnv (34-96)
• env (23-27)
• close (51-52)
• create_account (54-67)

src/hiero_sdk_python/query/query.py (1)

• set_max_query_payment (96-124)

src/hiero_sdk_python/query/query.py (4)

• set_max_query_payment (96-124)
• _is_payment_required (414-421)
• get_cost (281-321)
• _before_execute (126-157)

src/hiero_sdk_python/client/client.py (1)

• set_default_max_query_payment (249-274)

src/hiero_sdk_python/hbar.py (1)

• Hbar (18-213)

src/hiero_sdk_python/client/client.py (2)

• Client (32-287)
• set_default_max_query_payment (249-274)

src/hiero_sdk_python/contract/contract_call_query.py (5)

• ContractCallQuery (27-233)
• set_contract_id (59-67)
• set_gas (69-77)
• set_function (107-124)
• execute (190-216)

src/hiero_sdk_python/query/query.py (2)

• get_cost (281-321)
• set_max_query_payment (96-124)

src/hiero_sdk_python/contract/contract_call_query.py (1)

• ContractCallQuery (27-233)

src/hiero_sdk_python/query/query.py (2)

• get_cost (281-321)
• set_max_query_payment (96-124)

96-96: Use X | Y for type annotations

Convert to X | Y

(UP007)

113-115: Avoid specifying long messages outside the exception class

(TRY003)

119-119: Avoid specifying long messages outside the exception class

(TRY003)

154-157: Avoid specifying long messages outside the exception class

(TRY003)

7-7: typing.List is deprecated, use list instead

(UP035)

249-249: Use X | Y for type annotations

Convert to X | Y

(UP007)

263-265: Avoid specifying long messages outside the exception class

(TRY003)

269-269: Avoid specifying long messages outside the exception class

(TRY003)

243-243: Redefinition of unused env from line 12

(F811)

255-255: pytest.raises(ValueError) is too broad, set the match parameter or use a more specific exception

(PT011)

259-259: Assertion should be broken down into multiple parts

Break down assertion into multiple parts

(PT018)

251-251: Avoid equality comparisons to True; use query_requires_payment._is_payment_required(): for truth checks

Replace with query_requires_payment._is_payment_required()

(E712)

254-254: Wrong type passed to first argument of pytest.mark.parametrize; expected tuple

Use a tuple for the first argument

(PT006)

192-192: Wrong type passed to first argument of pytest.mark.parametrize; expected tuple

Use a tuple for the first argument

(PT006)

⚙️ CodeRabbit configuration file

tests/unit/**/*: You are acting as a senior maintainer reviewing unit tests for the hiero-sdk-python project. Your goal is to ensure tests are extensive, deterministic, and protect against breaking changes.

CRITICAL PRINCIPLES - Tests Must Fail Loudly & Deterministically:

• Tests must provide useful error messages when they fail for future debugging.
• No print() statements - use assertions with descriptive messages.
• No timing-dependent or unseeded random assertions.
• No network calls or external dependencies (unit tests are isolated).
• No unjustified TODOs or skipped tests without tracking issues.

PRIORITY 1 - Protect Against Breaking Changes:

• Assert public attributes exist (e.g., assert hasattr(obj, 'account_id')).
• Assert return types where relevant (e.g., assert isinstance(result, AccountId)).
• Assert fluent setters return self (e.g., assert tx.set_memo("test") is tx).
• Assert backward-compatible defaults are maintained.
• If a breaking change is introduced, tests must assert deprecation behavior and test old behavior until removal.

PRIORITY 2 - Constructor & Setter Behavior:

• Test constructor behavior with valid inputs, edge cases, and invalid inputs.
• Test setter behavior including method chaining (fluent interface).
• Verify that setters validate input and raise appropriate exceptions.
• Test that getters return expected values after construction/setting.

PRIORITY 3 - Comprehensive Coverage:

• Unit tests should be extensive - test even if we don't expect users to use it currently.
• Cover happy paths AND unhappy paths/edge cases.
• Test boundary conditions, null/None values, empty collections, etc.
• Avoid brittle ordering assertions unless order is part of the contract.

PRIORITY 4 - No Mocks for Non-Existent Modules:

• All imports must reference actual SDK modules - no hallucinated paths.
• Validate import paths against the actual src/hiero_sdk_python structure.
• Mocks should only be used for external de...

Files:

• tests/unit/query_test.py

⚙️ CodeRabbit configuration file

src/hiero_sdk_python/query/**/*.py: You are acting as a senior maintainer reviewing the Query base class
and its subclasses for the hiero-sdk-python project.

NOTE:

• Review focus levels indicate areas that are important to check carefully.
• They do NOT imply severity or urgency.
• Only recommend fixes when there is a clear behavioral regression.

Scope is STRICTLY LIMITED to:

• Changes to the base Query class
• Changes to existing Query subclasses
• Newly added Query subclasses

---

REVIEW FOCUS 1 — QUERY SEMANTICS & PAYMENT BEHAVIOR
(CONTRACTUAL / HIGH SENSITIVITY)

Queries do not reach consensus and use QueryHeader for payment and responseType.

The following behaviors are contractual and must remain unchanged:

• _is_payment_required() semantics
• FREE vs PAID query classification
• COST_ANSWER vs ANSWER_ONLY behavior
• Whether a payment transaction is attached

Good to check and verify that changes do NOT:

• Alter FREE → PAID or PAID → FREE behavior
• Attach payment to COST_ANSWER queries
• Bypass get_cost(client) for paid queries
• Hardcode fees or override payment logic

---

REVIEW FOCUS 2 — EXECUTION LIFECYCLE & BASE CLASS INTEGRITY

All queries MUST:

• Use the base Query execution flow
• Delegate retries, backoff, and node selection to _Executable
• Call _before_execute(client) before _execute(client)

Subclasses MUST NOT:

• Override retry logic
• Implement custom node selection
• Manage gRPC deadlines manually
• Bypass _Executable state handling

Flag deviations for review; recommend fixes only if behavior changes.

---

REVIEW FOCUS 3 — REQUEST CONSTRUCTION CONTRACT

_make_request() MUST:

• Validat...

Files:

• src/hiero_sdk_python/query/query.py

src/hiero_sdk_python/query/query.py (4)

• set_max_query_payment (96-128)
• _is_payment_required (418-425)
• get_cost (285-325)
• _before_execute (130-161)

src/hiero_sdk_python/client/client.py (1)

• set_default_max_query_payment (249-278)

src/hiero_sdk_python/hbar.py (1)

• Hbar (18-213)

src/hiero_sdk_python/hbar.py (2)

• Hbar (18-213)
• to_hbars (67-71)

253-253: Avoid equality comparisons to True; use query_requires_payment._is_payment_required(): for truth checks

Replace with query_requires_payment._is_payment_required()

(E712)

256-256: Wrong type passed to first argument of pytest.mark.parametrize; expected tuple

Use a tuple for the first argument

(PT006)

283-283: f-string without any placeholders

Remove extraneous f prefix

(F541)

7-7: typing.List is deprecated, use list instead

(UP035)

249-249: Use X | Y for type annotations

Convert to X | Y

(UP007)

263-265: Avoid specifying long messages outside the exception class

(TRY003)

269-269: Avoid specifying long messages outside the exception class

(TRY003)

275-275: Avoid specifying long messages outside the exception class

(TRY003)

96-96: Use X | Y for type annotations

Convert to X | Y

(UP007)

113-115: Avoid specifying long messages outside the exception class

(TRY003)

119-119: Avoid specifying long messages outside the exception class

(TRY003)

125-125: Avoid specifying long messages outside the exception class

(TRY003)

158-161: Avoid specifying long messages outside the exception class

(TRY003)

⚙️ CodeRabbit configuration file

tests/unit/**/*: You are acting as a senior maintainer reviewing unit tests for the hiero-sdk-python project. Your goal is to ensure tests are extensive, deterministic, and protect against breaking changes.

CRITICAL PRINCIPLES - Tests Must Fail Loudly & Deterministically:

• Tests must provide useful error messages when they fail for future debugging.
• No print() statements - use assertions with descriptive messages.
• No timing-dependent or unseeded random assertions.
• No network calls or external dependencies (unit tests are isolated).
• No unjustified TODOs or skipped tests without tracking issues.

PRIORITY 1 - Protect Against Breaking Changes:

• Assert public attributes exist (e.g., assert hasattr(obj, 'account_id')).
• Assert return types where relevant (e.g., assert isinstance(result, AccountId)).
• Assert fluent setters return self (e.g., assert tx.set_memo("test") is tx).
• Assert backward-compatible defaults are maintained.
• If a breaking change is introduced, tests must assert deprecation behavior and test old behavior until removal.

PRIORITY 2 - Constructor & Setter Behavior:

• Test constructor behavior with valid inputs, edge cases, and invalid inputs.
• Test setter behavior including method chaining (fluent interface).
• Verify that setters validate input and raise appropriate exceptions.
• Test that getters return expected values after construction/setting.

PRIORITY 3 - Comprehensive Coverage:

• Unit tests should be extensive - test even if we don't expect users to use it currently.
• Cover happy paths AND unhappy paths/edge cases.
• Test boundary conditions, null/None values, empty collections, etc.
• Avoid brittle ordering assertions unless order is part of the contract.

PRIORITY 4 - No Mocks for Non-Existent Modules:

• All imports must reference actual SDK modules - no hallucinated paths.
• Validate import paths against the actual src/hiero_sdk_python structure.
• Mocks should only be used for external de...

Files:

• tests/unit/query_test.py

⚙️ CodeRabbit configuration file

src/hiero_sdk_python/query/**/*.py: You are acting as a senior maintainer reviewing the Query base class
and its subclasses for the hiero-sdk-python project.

NOTE:

• Review focus levels indicate areas that are important to check carefully.
• They do NOT imply severity or urgency.
• Only recommend fixes when there is a clear behavioral regression.

Scope is STRICTLY LIMITED to:

• Changes to the base Query class
• Changes to existing Query subclasses
• Newly added Query subclasses

---

REVIEW FOCUS 1 — QUERY SEMANTICS & PAYMENT BEHAVIOR
(CONTRACTUAL / HIGH SENSITIVITY)

Queries do not reach consensus and use QueryHeader for payment and responseType.

The following behaviors are contractual and must remain unchanged:

• _is_payment_required() semantics
• FREE vs PAID query classification
• COST_ANSWER vs ANSWER_ONLY behavior
• Whether a payment transaction is attached

Good to check and verify that changes do NOT:

• Alter FREE → PAID or PAID → FREE behavior
• Attach payment to COST_ANSWER queries
• Bypass get_cost(client) for paid queries
• Hardcode fees or override payment logic

---

REVIEW FOCUS 2 — EXECUTION LIFECYCLE & BASE CLASS INTEGRITY

All queries MUST:

• Use the base Query execution flow
• Delegate retries, backoff, and node selection to _Executable
• Call _before_execute(client) before _execute(client)

Subclasses MUST NOT:

• Override retry logic
• Implement custom node selection
• Manage gRPC deadlines manually
• Bypass _Executable state handling

Flag deviations for review; recommend fixes only if behavior changes.

---

REVIEW FOCUS 3 — REQUEST CONSTRUCTION CONTRACT

_make_request() MUST:

• Validat...

Files:

• src/hiero_sdk_python/query/query.py

src/hiero_sdk_python/hbar.py (1)

• Hbar (18-213)

src/hiero_sdk_python/query/query.py (4)

• set_max_query_payment (96-128)
• _is_payment_required (418-425)
• get_cost (285-325)
• _before_execute (130-161)

src/hiero_sdk_python/client/client.py (1)

• set_default_max_query_payment (249-278)

src/hiero_sdk_python/hbar.py (2)

• Hbar (18-213)
• to_hbars (67-71)

7-7: typing.List is deprecated, use list instead

(UP035)

249-249: Use X | Y for type annotations

Convert to X | Y

(UP007)

263-265: Avoid specifying long messages outside the exception class

(TRY003)

269-269: Avoid specifying long messages outside the exception class

(TRY003)

275-275: Avoid specifying long messages outside the exception class

(TRY003)

253-253: Avoid equality comparisons to True; use query_requires_payment._is_payment_required(): for truth checks

Replace with query_requires_payment._is_payment_required()

(E712)

256-256: Wrong type passed to first argument of pytest.mark.parametrize; expected tuple

Use a tuple for the first argument

(PT006)

96-96: Use X | Y for type annotations

Convert to X | Y

(UP007)

113-115: Avoid specifying long messages outside the exception class

(TRY003)

119-119: Avoid specifying long messages outside the exception class

(TRY003)

125-125: Avoid specifying long messages outside the exception class

(TRY003)

158-161: Avoid specifying long messages outside the exception class

(TRY003)